From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 23 Jan 2025 19:16:45 +0000 (+0100)
Subject: st/adjustment: Remove return value from private setters
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~153^2^2~54
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4092882005c1adcc8c58ddda49a8e7ee293ddde8;p=gnome-shell.git

st/adjustment: Remove return value from private setters

Nothing is using the return value, so the methods can just follow
the usual pattern for setters.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3620>
---

diff --git a/src/st/st-adjustment.c b/src/st/st-adjustment.c
index b9d6d592e..05384e879 100644
--- a/src/st/st-adjustment.c
+++ b/src/st/st-adjustment.c
@@ -97,16 +97,16 @@ typedef struct _TransitionClosure
   gulong completed_id;
 } TransitionClosure;
 
-static gboolean st_adjustment_set_lower          (StAdjustment *adjustment,
-                                                  gdouble       lower);
-static gboolean st_adjustment_set_upper          (StAdjustment *adjustment,
-                                                  gdouble       upper);
-static gboolean st_adjustment_set_step_increment (StAdjustment *adjustment,
-                                                  gdouble       step);
-static gboolean st_adjustment_set_page_increment (StAdjustment *adjustment,
-                                                  gdouble       page);
-static gboolean st_adjustment_set_page_size      (StAdjustment *adjustment,
-                                                  gdouble       size);
+static void st_adjustment_set_lower          (StAdjustment *adjustment,
+                                              double        lower);
+static void st_adjustment_set_upper          (StAdjustment *adjustment,
+                                              double        upper);
+static void st_adjustment_set_step_increment (StAdjustment *adjustment,
+                                              double        step);
+static void st_adjustment_set_page_increment (StAdjustment *adjustment,
+                                              double        page);
+static void st_adjustment_set_page_size      (StAdjustment *adjustment,
+                                              double        size);
 
 static ClutterActor *
 st_adjustment_get_actor (ClutterAnimatable *animatable)
@@ -579,7 +579,7 @@ st_adjustment_clamp_page (StAdjustment *adjustment,
  * Alternatively, [method@St.Adjustment.set_values] can be used to compress
  * #GObject::notify and [signal@St.Adjustment::changed] emissions.
  */
-static gboolean
+static void
 st_adjustment_set_lower (StAdjustment *adjustment,
                          gdouble       lower)
 {
@@ -594,11 +594,7 @@ st_adjustment_set_lower (StAdjustment *adjustment,
       /* Defer clamp until after construction. */
       if (!priv->is_constructing)
         st_adjustment_clamp_page (adjustment, priv->lower, priv->upper);
-
-      return TRUE;
     }
-
-  return FALSE;
 }
 
 /**
@@ -613,10 +609,8 @@ st_adjustment_set_lower (StAdjustment *adjustment,
  *
  * See [method@St.Adjustment.set_lower] about how to compress multiple
  * signal emissions when setting multiple adjustment properties.
- *
- * Returns: %TRUE if the value was changed
  */
-static gboolean
+static void
 st_adjustment_set_upper (StAdjustment *adjustment,
                          gdouble       upper)
 {
@@ -631,11 +625,7 @@ st_adjustment_set_upper (StAdjustment *adjustment,
       /* Defer clamp until after construction. */
       if (!priv->is_constructing)
         st_adjustment_clamp_page (adjustment, priv->lower, priv->upper);
-
-      return TRUE;
     }
-
-  return FALSE;
 }
 
 /**
@@ -647,10 +637,8 @@ st_adjustment_set_upper (StAdjustment *adjustment,
  *
  * See [method@St.Adjustment.set_lower] about how to compress multiple
  * signal emissions when setting multiple adjustment properties.
- *
- * Returns: %TRUE if the value was changed
  */
-static gboolean
+static void
 st_adjustment_set_step_increment (StAdjustment *adjustment,
                                   gdouble       step)
 {
@@ -661,11 +649,7 @@ st_adjustment_set_step_increment (StAdjustment *adjustment,
       priv->step_increment = step;
 
       g_object_notify_by_pspec (G_OBJECT (adjustment), props[PROP_STEP_INC]);
-
-      return TRUE;
     }
-
-  return FALSE;
 }
 
 /**
@@ -677,10 +661,8 @@ st_adjustment_set_step_increment (StAdjustment *adjustment,
  *
  * See [method@St.Adjustment.set_lower] about how to compress multiple
  * signal emissions when setting multiple adjustment properties.
- *
- * Returns: %TRUE if the value was changed
  */
-static gboolean
+static void
 st_adjustment_set_page_increment (StAdjustment *adjustment,
                                   gdouble       page)
 {
@@ -691,11 +673,7 @@ st_adjustment_set_page_increment (StAdjustment *adjustment,
       priv->page_increment = page;
 
       g_object_notify_by_pspec (G_OBJECT (adjustment), props[PROP_PAGE_INC]);
-
-      return TRUE;
     }
-
-  return FALSE;
 }
 
 /**
@@ -707,10 +685,8 @@ st_adjustment_set_page_increment (StAdjustment *adjustment,
  *
  * See [method@St.Adjustment.set_lower] about how to compress multiple
  * signal emissions when setting multiple adjustment properties.
- *
- * Returns: %TRUE if the value was changed
  */
-static gboolean
+static void
 st_adjustment_set_page_size (StAdjustment *adjustment,
                              gdouble       size)
 {
@@ -725,11 +701,7 @@ st_adjustment_set_page_size (StAdjustment *adjustment,
       /* We'll explicitly clamp after construction. */
       if (!priv->is_constructing)
         st_adjustment_clamp_page (adjustment, priv->lower, priv->upper);
-
-      return TRUE;
     }
-
-  return FALSE;
 }
 
 /**